Store object metadata in metabases for SearchV2 service #3080
+1,059
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cthulhu-rider
commented
Jan 13, 2025
•
cthulhu-rider
commented
- store metadata on Put
- unfiltered
- test scenarios for filtered
- filtered
- removal
cthulhu-rider
force-pushed
the
object-searchv2/metabases
branch
4 times, most recently
from
9624b00 to
3540889
Compare
Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
object-searchv2/metabases
branch
from
3540889 to
baf055c
Compare
Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
object-searchv2/metabases
branch
from
f16c1c1 to
8957af6
Compare
| ) | ||
|
|
||
| var ( | ||
| maxUint256 = new(big.Int).SetBytes([]byte{255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, |
There was a problem hiding this comment.
Isn't it 127, 255, 255...? At least VM has signed 256-bit integers.
There was a problem hiding this comment.
BTW, https://github.com/holiman/uint256 can be useful here, it's much faster than elastic big.Int (refs nspcc-dev/neo-go#1581).
| metaPrefixA = byte(iota) | ||
| metaPrefixBI // integer attributes | ||
| metaPrefixBS // all other attributes | ||
| metaPrefixC |
There was a problem hiding this comment.
These better be named semantically.
There was a problem hiding this comment.
for sure, will do this finally. But for, now I'm used to naming from the task
| var k []byte | ||
| // TODO: move to global funcs | ||
| makeKeyB := func(prefix byte, attr string, valLen int) (int, int) { | ||
| ln := 1 + oid.Size + len(attr) + valLen + len(utf8Delimiter)*2 // TODO: constantize some stuff |
There was a problem hiding this comment.
yeah i thought about this. Will make code improvement after functionaly stabilization if u dont mind
cthulhu-rider
force-pushed
the
object-searchv2/metabases
branch
2 times, most recently
from
41de769 to
c29b7e5
Compare
Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
object-searchv2/metabases
branch
from
c29b7e5 to
00c7b83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.