services/object: Inline metric handler #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use op enum to have one method for all ops. Submit success and duration in one call. Signed-off-by: Leonard Lyubich <[email protected]>
It's invisible outside anyway. Signed-off-by: Leonard Lyubich <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3083 +/- ##
==========================================
+ Coverage 22.21% 22.24% +0.03%
==========================================
Files 772 771 -1
Lines 59025 58950 -75
==========================================
+ Hits 13112 13115 +3
+ Misses 45027 44950 -77
+ Partials 886 885 -1 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
requested review from
roman-khimov and
carpawell
as code owners
Continues c5b0800. This inlines one level of recurrent object services into the gRPC server implementation. The behavior is kept. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
avoid-apigo-objsvc
branch
from
5fb3855 to
1e40321
Compare
roman-khimov
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one more cut from #3057, continues #3081
to be continued