Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/object: Inline signing service #3084

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cthulhu-rider
Copy link
Contributor

Continues 1e40321. Now sign service is gone.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 7.93651% with 116 lines in your changes missing coverage. Please review.

Project coverage is 22.29%. Comparing base (b9fbe92) to head (c56a885).

Files with missing lines Patch % Lines
pkg/services/object/server.go 4.20% 114 Missing ⚠️
cmd/neofs-node/object.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3084      +/-   ##
==========================================
+ Coverage   22.24%   22.29%   +0.05%     
==========================================
  Files         771      770       -1     
  Lines       58950    58806     -144     
==========================================
- Hits        13113    13111       -2     
+ Misses      44951    44809     -142     
  Partials      886      886              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Continues 1e40321. Now sign service is gone.

Signed-off-by: Leonard Lyubich <[email protected]>
@cthulhu-rider cthulhu-rider marked this pull request as ready for review January 20, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant