-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync first epoch duration at application startup #708
Sync first epoch duration at application startup #708
Conversation
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
==========================================
+ Coverage 44.30% 44.37% +0.06%
==========================================
Files 211 211
Lines 9688 9700 +12
==========================================
+ Hits 4292 4304 +12
- Misses 5043 5044 +1
+ Partials 353 352 -1
Continue to review full report at Codecov.
|
To process single event in the future, I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it took some time for me to get the idea of what EpochBlock
returns, i had to go to read it in contract code
wouldn't it be better to add smth like "last" or "start" or both to the method name?
I thought about that. |
yes, it sounds better for me |
Signed-off-by: Alex Vanin <[email protected]>
Signed-off-by: Alex Vanin <[email protected]>
Signed-off-by: Alex Vanin <[email protected]>
When Inner Ring node starts, it should sync nearest epoch tick event based on the block of the latest epoch. Otherwise epoch ticking can be stopped, because ballots or notary transactions are valid for limited period of time. Signed-off-by: Alex Vanin <[email protected]>
Signed-off-by: Alex Vanin <[email protected]>
Closes #679
At the startup, Inner Ring application calculates block duration before next epoch tick and processes new epoch event at this block.