check response message size is positive

nsqio · Sep 26, 2019 · 9f320ad · 9f320ad
1 parent 61f49c0
commit 9f320ad
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/protocol.go b/protocol.go
@@ -3,6 +3,7 @@ package nsq
 import (
 	"encoding/binary"
 	"errors"
+	"fmt"
 	"io"
 	"regexp"
 )
@@ -56,6 +57,9 @@ func ReadResponse(r io.Reader) ([]byte, error) {
 		return nil, err
 	}
 
+	if msgSize < 0 {
+		return nil, fmt.Errorf("response msg size is negative: %v", msgSize)
+	}
 	// message binary data
 	buf := make([]byte, msgSize)
 	_, err = io.ReadFull(r, buf)