go-vet: assignment copies lock value of tls.Config

[iaburton]

While there are some minor linting issues, I noticed go-vet pointing out

assignment copies lock value to conf: crypto/tls.Config contains sync.Once contains sync.Mutex

Here:

go-nsq/conn.go

Line 390 in 61f49c0

conf = *tlsConf

Since the tls.Config is an option in the nsq.Config, you can't be certain it isn't already being used, and therefore synchronization of the Once/Mutex are lost in the copied value. Depending on the minimum Go version this package supports, the solution might be as simple as Cloning the tls.Config with the provided method added in Go1.8 https://golang.org/pkg/crypto/tls/#Config.Clone

[ploxiln]

We don't try to support go < 1.8, Clone() will do fine. Want to open a pull request with that change?

[iaburton]

Done 👍

[ploxiln]

closing in favor of #255