Per-message Requeue #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue delays on message-by-message basis
|
Yea, I agree. I terribly regret not using go time types for the public interface though... sigh thanks @davegardnerisme |
|
👍 |
|
The main downside is that I always have to go the playground to make sure I'm turning things into milliseconds correctly ;) |
|
it's even easier... milliseconds := int(d/time.Millisecond) |
|
Genius. I knew I was being stupid. On Fri, Oct 4, 2013 at 8:57 PM, Matt Reiferson [email protected]:
|
sthulb
pushed a commit
to HailoOSS/go-nsq
that referenced
this pull request
Sep 14, 2016
Unpin from our fork of go-snappystream
amosir
pushed a commit
to amosir/go-nsq
that referenced
this pull request
Jan 16, 2024
fix blocking Depth() call on the closed queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
Requeue()method to messages for fine-grained control on requeue delays on message-by-message basis.Copied the same approach used as for
Touch().Copied the same interface for
Requeue-- withtimeoutMs intrather than a Go Duration - as it seemed a better fit with the existing codebase.