message: atomic races #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RFR @jehiah |
| } | ||
|
|
||
| // Touch sends a TOUCH command to the nsqd which | ||
| // sent this message | ||
| func (m *Message) Touch() { | ||
| if m.HasResponded() { | ||
| if !atomic.CompareAndSwapInt32(&m.responded, 0, 1) { |
There was a problem hiding this comment.
just LoadInt32 here since we don't want Touch() to mark as responded.
mreiferson
force-pushed
the
races_120
branch
from
6167bc9 to
efe81cd
Compare
|
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there was the possibility of a race since we were separately checking/storing
cc @schmichael