consumer: don't run redistribute without connections #132
Conversation
|
FYI the block of code in question that sets https://github.com/bitly/go-nsq/blob/master/consumer.go#L698-L706 Another, perhaps more reliable way to approach this would be to convert those rules into active rules that are continually evaluated when Any suggestions @jehiah? |
| @@ -114,6 +114,9 @@ type Config struct { | |||
| LookupdPollInterval time.Duration `opt:"lookupd_poll_interval" min:"5s" max:"5m" default:"60s"` | |||
| LookupdPollJitter float64 `opt:"lookupd_poll_jitter" min:"0" max:"1" default:"0.3"` | |||
|
|
|||
| // Duration between reconnect attempts when connecting directly to nsqd (i.e not using nsqlookupd) | |||
| ReconnectInterval time.Duration `opt:"reconnect_interval" min:"0" max:"1m" default:"15s"` | |||
There was a problem hiding this comment.
I dislike having separate variables for the reconnect interval using nsqd directly vs using lookupd. It's a shame the var for lookupd is named as such because this is probably a better name.
do you feel comfortable just re-using LookupdPollInterval ?
|
i dig this change. I don't think it's worth trying to rewrite this code to tackle these situations differently (or at least i don't have a sufficiently clear idea of what that would look like). on the plus side, our test coverage is getting better =) |
|
also, FYI this new test failed against at least the last 2 stable releases.... 😦 |
I think it's worth it if only because it's the only spot where RDY redistribution is enabled outside of the actual function (which is why it was susceptible to this bug in the first place). Whether we fix it now is a different question. |
mreiferson
force-pushed
the
deadlocks_132
branch
from
29fe0a9 to
2e31ccc
Compare
|
@jehiah updated (sorry for squashing) |
consumer: don't run redistribute without connections
This fixes #130 and #131.
The scenario is:
We were (correctly) setting the redistribute flag, but it was attempting
to redistribute without having any connections.
This fix ensures that if an external heuristic sets the redistribute flag
it won't run proceed unless there are connections.
RFR @jehiah
/cc @twmb @zhangdaoling