go vet, golint, fmt fix

config.go

@@ -544,7 +544,7 @@ func coerce(v interface{}, typ reflect.Type) (reflect.Value, error) {
 		v, err = coerceBackoffStrategy(v)
 	default:
 		v = nil
-		err = errors.New(fmt.Sprintf("invalid type %s", typ.String()))
+		err = fmt.Errorf("invalid type %s", typ.String())
 	}
 	return valueTypeCoerce(v, typ), err
 }
@@ -576,10 +576,8 @@ func coerceString(v interface{}) (string, error) {
 		return fmt.Sprintf("%d", v), nil
 	case float32, float64:
 		return fmt.Sprintf("%f", v), nil
-	default:
-		return fmt.Sprintf("%s", v), nil
 	}
-	return "", errors.New("invalid value type")
+	return fmt.Sprintf("%s", v), nil
 }
 
 func coerceDuration(v interface{}) (time.Duration, error) {

conn.go

@@ -465,7 +465,8 @@ func (c *Conn) auth(secret string) error {
 		return err
 	}
 
-	c.log(LogLevelInfo, "Auth accepted. Identity: %q %s Permissions: %d", resp.Identity, resp.IdentityUrl, resp.PermissionCount)
+	c.log(LogLevelInfo, "Auth accepted. Identity: %q %s Permissions: %d",
+		resp.Identity, resp.IdentityUrl, resp.PermissionCount)
 
 	return nil
 }

consumer.go

@@ -335,7 +335,7 @@ func (r *Consumer) ConnectToNSQLookupd(addr string) error {
 	return nil
 }
 
-// ConnectToNSQLookupd adds multiple nsqlookupd address to the list for this Consumer instance.
+// ConnectToNSQLookupds adds multiple nsqlookupd address to the list for this Consumer instance.
 //
 // If adding the first address it initiates an HTTP request to discover nsqd
 // producers for the configured topic.
@@ -462,7 +462,7 @@ func (r *Consumer) queryLookupd() {
 		return
 	}
 
-	nsqdAddrs := make([]string, 0)
+	var nsqdAddrs []string
 	for _, producer := range data.Producers {
 		broadcastAddress := producer.BroadcastAddress
 		port := producer.TCPPort
@@ -482,7 +482,7 @@ func (r *Consumer) queryLookupd() {
 	}
 }
 
-// ConnectToNSQD takes multiple nsqd addresses to connect directly to.
+// ConnectToNSQDs takes multiple nsqd addresses to connect directly to.
 //
 // It is recommended to use ConnectToNSQLookupd so that topics are discovered
 // automatically.  This method is useful when you want to connect to local instance.
@@ -622,7 +622,7 @@ func (r *Consumer) DisconnectFromNSQLookupd(addr string) error {
 	}
 
 	if len(r.lookupdHTTPAddrs) == 1 {
-		return errors.New(fmt.Sprintf("cannot disconnect from only remaining nsqlookupd HTTP address %s", addr))
+		return fmt.Errorf("cannot disconnect from only remaining nsqlookupd HTTP address %s", addr)
 	}
 
 	r.lookupdHTTPAddrs = append(r.lookupdHTTPAddrs[:idx], r.lookupdHTTPAddrs[idx+1:]...)
@@ -732,7 +732,7 @@ func (r *Consumer) onConnClose(c *Conn) {
 		// try to reconnect after a bit
 		go func(addr string) {
 			for {
-				r.log(LogLevelInfo, "(%s) re-connecting in %.04f seconds...", addr, r.config.LookupdPollInterval)
+				r.log(LogLevelInfo, "(%s) re-connecting in %s", addr, r.config.LookupdPollInterval)
 				time.Sleep(r.config.LookupdPollInterval)
 				if atomic.LoadInt32(&r.stopFlag) == 1 {
 					break

delegates.go

@@ -9,6 +9,7 @@ type logger interface {
 // LogLevel specifies the severity of a given log message
 type LogLevel int
 
+// Log levels
 const (
 	LogLevelDebug LogLevel = iota
 	LogLevelInfo

version.go

@@ -1,4 +1,4 @@
-// nsq is the official Go package for NSQ (http://nsq.io/)
+// Package nsq is the official Go package for NSQ (http://nsq.io/)
 //
 // It provides high-level Consumer and Producer types as well as low-level
 // functions to communicate over the NSQ protocol