Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging: fix 'backing off for x' message formatting #202

Merged
merged 1 commit into from
Dec 22, 2016
Merged

logging: fix 'backing off for x' message formatting #202

merged 1 commit into from
Dec 22, 2016

Conversation

jehiah
Copy link
Member

@jehiah jehiah commented Dec 22, 2016

I noticed the following in my logs recently

2016/12/22 15:05:27 consumer.go:844: WRN    1 [chaunceys_log/notificationsd] backing off for %!f(int=0001) seconds

This fixes related messages to always use %s for time.Duration types for backoff log messages.

RFR @mreiferson

@jehiah jehiah added the bug label Dec 22, 2016
@mreiferson mreiferson merged commit 1f76a74 into nsqio:master Dec 22, 2016
@mreiferson mreiferson deleted the backoff_log_msg_fix_202 branch December 22, 2016 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mreiferson mreiferson mreiferson approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jehiah @mreiferson