Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to golang/snappy #203

Merged
merged 1 commit into from
Dec 29, 2016
Merged

switch to golang/snappy #203

merged 1 commit into from
Dec 29, 2016

Conversation

jehiah
Copy link
Member

@jehiah jehiah commented Dec 29, 2016

This matches nsqio/nsq#830

@mreiferson
Copy link
Member

Hah! good catch.

mreiferson
mreiferson approved these changes Dec 29, 2016
View reviewed changes
Copy link
Member

@mreiferson mreiferson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jehiah
Copy link
Member Author

jehiah commented Dec 29, 2016

Also nsq Godeps needs to bump it's dependency of go-nsq to pick up this change; presumably it should have broken the build w/o this?

@mreiferson
Copy link
Member

Also nsq Godeps needs to bump it's dependency of go-nsq to pick up this change; presumably it should have broken the build w/o this?

That's interesting, I can't explain how it succeeded...

@mreiferson mreiferson merged commit a53d495 into nsqio:master Dec 29, 2016
@mreiferson mreiferson deleted the snappy_switch_203 branch December 29, 2016 18:58
andyxning added a commit to andyxning/go-nsq that referenced this pull request Sep 22, 2019
@andyxning
backport nsqio#203
5f54919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mreiferson mreiferson mreiferson approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jehiah @mreiferson