adding user_agent string to IDENTIFY #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -635,6 +638,7 @@ func (q *Reader) ConnectToNSQ(addr string) error { | |||
| ci["snappy"] = q.Snappy | |||
| ci["feature_negotiation"] = true | |||
| ci["sample_rate"] = q.SampleRate | |||
| ci["user_agent"] = q.UserAgent | |||
There was a problem hiding this comment.
the way I envisioned user_agent to work is that it would typically be set to the name/version of the client library... i.e. go-nsq/0.3.5-alpha
Perhaps the end-user UserAgent property should be appended to the above, in parentheses, like it would in HTTP:
userAgent := fmt.Sprintf("go-nsq/%s", VERSION)
if q.UserAgent != "" {
userAgent = fmt.Sprintf("%s (%s)", userAgent, q.UserAgent)
}
ci["user_agent"] = userAgent
|
After giving this some thought, the user_agent string should be allowed to be changed. But I think overall it should work similar to curl. This means that the user_agent string has a default (similar to the one you set above). Beyond that, it should be customizable. |
|
ok, this seems reasonable to me, go ahead with that approach (same for pynsq) |
| @@ -123,7 +123,8 @@ type Reader struct { | |||
| DeflateLevel int // the compression level to negotiate for Deflate | |||
| Snappy bool // negotiate enabling Snappy compression | |||
|
|
|||
| SampleRate int32 // set the sampleRate of the client's messagePump (requires nsqd 0.2.25+) | |||
| SampleRate int32 // set the sampleRate of the client's messagePump (requires nsqd 0.2.25+) | |||
| UserAgent string // set the user agent string of the client in the spirit of HTTP (default: "<client_library_name>/<version>") (requires nsqd 0.2.25+) | |||
There was a problem hiding this comment.
// a string identifying the agent for this client in the spirit of HTTP (default: "<client_library_name>/<version>")
|
👍 thanks @elubow |
mreiferson
added a commit
that referenced
this pull request
Jan 31, 2014
adding user_agent string to IDENTIFY
amosir
pushed a commit
to amosir/go-nsq
that referenced
this pull request
Jan 16, 2024
proper handling of maxBytesPerFile for reads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding user agent string