fix connection setup read buffering (flakey tests) #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(this was identified due to flakey Snappy tests) if nsqd sends the IDENTIFY + handshake packets together then go-nsq reads and buffers both, preventing an UpgradeX() from being able to access the handshake data because we were wrapping the underlying connection and not the buffered one. fix this by not buffering at all during connection setup and enabling it before handoff.
|
RFR @jehiah |
jehiah
added a commit
that referenced
this pull request
Feb 1, 2014
fix connection setup read buffering (flakey tests)
amosir
pushed a commit
to amosir/go-nsq
that referenced
this pull request
Jan 16, 2024
Add PeekChan function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit message