Code

public API refactoring#30

Code

Merged

jehiah merged 32 commits intonsqio:masternsqio/go-nsq:masterfrom mreiferson:public_api_30mreiferson/go-nsq:public_api_30Copy head branch name to clipboardMay 26, 2014

+2,204-2,078

Commits

Commits on May 25, 2014

• reader/writer: refactor configuration

  mreiferson

  committed
  c303198

• command: refactor to implement WriteTo interface; drop binary.Write

  mreiferson

  committed
  4e267e8

• conn/reader/writer: refactor write buffering; switch to WriteCommand

  mreiferson

  committed
  baaa363

• reader/conn: update comments; go fmt

  mreiferson

  committed
  7f1b245

• writer: simplify public error handling

  mreiferson

  committed
  fffdd4c

• test: fix fatal test output

  mreiferson

  committed
  fa643f3

• message/command: use callback API for message responses; switch to time.Duration for Requeue

  mreiferson

  committed
  822f1c1

• conn: expose FIN/REQ callbacks; refactor Message response plumbing

  mreiferson

  committed
  31c80db

• reader: remove AsyncHandler interface

  mreiferson

  committed
  16673ed

• conn: close read side first, then write; trap conn closed errors

  mreiferson

  committed
  803365c

• conn: don't publicly embed net.Conn

  mreiferson

  committed
  70cf198

• reader/conn: s/Stop/Close; CloseRead if no messages in flight upon Close(); refactor

  mreiferson

  committed
  6a5997e

• reader: use wg for rdyLoop and lookupdLoop; s/ExitChan/StopChan

  mreiferson

  committed
  fff3368

• reader/writer/conn: conn doesn't take topic/channel

  mreiferson

  committed
  88ee1b9

• reader: add global reader instance counter

  mreiferson

  committed
  9b7d6f3

• reader: consistent exit path for long running handler goroutine

  mreiferson

  committed
  e260758

• reader/writer/conn: drop individual callbacks for delegate interface

  mreiferson

  committed
  b1e3b77

• reader: comment fixes; make atomic counters private

  mreiferson

  committed
  6d9c225

• reader/conn: un-export embedded sync.RWMutex

  mreiferson

  committed
  8929d25

• reader/writer/conn: log levels and delegates

  mreiferson

  committed
  65d8c5a

• reader/conn: add requeue without backoff

  mreiferson

  committed
  1099f5b

• reader: add HandlerFunc helper interface

  mreiferson

  committed
  07a9461

• message: drop EncodeBytes; s/Write/WriteTo; drop binary.{Read,Write}

  mreiferson

  committed
  d7aa9bd

• reader: consistent connect method names

  mreiferson

  committed
  1e5876a

• reader: drop SetMaxInFlight; un-export ConnectionMaxInFlight

  mreiferson

  committed
  fd1da49

• reader: s/AddHandler/SetHandler and change semantics

  mreiferson

  committed
  db8c50e

• reader: move around ReadUnpackedResponse

  mreiferson

  committed
  5a131ab

• un-export apiRequest and newDeadlineTransport

  mreiferson

  committed
  5b9217e

• reader/conn: capitalize message.ID

  mreiferson

  committed
  ccb206b

• golint

  mreiferson

  committed
  3543214

Commits on May 26, 2014

• reader/writer: rename to consumer/producer

  mreiferson

  committed
  c654a44

• bump v1.0.0-alpha

  mreiferson

  committed
  84426ed