Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable setting the max_attempts config option #39

Merged
merged 1 commit into from
Jun 1, 2014

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Jun 1, 2014

No description provided.

@mreiferson
Copy link
Member

@manveru thanks!

I'm curious, what was the actual issue you were seeing?

@mreiferson mreiferson added the bug label Jun 1, 2014
@manveru
Copy link
Contributor Author

manveru commented Jun 1, 2014

The error was the one below, and of course I noticed that you couldn't set it to 0 anymore like before, so I fixed both.

panic: reflect: call of reflect.Value.SetInt on uint16 Value

goroutine 1 [running]:
runtime.panic(0x84c6a0, 0xc210132440)
        /home/manveru/.gvm/gos/go1.2/src/pkg/runtime/panic.c:266 +0xb6
reflect.Value.SetInt(0x7aca20, 0xc210000a28, 0x96, 0x0)
        /home/manveru/.gvm/gos/go1.2/src/pkg/reflect/value.go:1457 +0xb7
github.com/bitly/go-nsq.valueTypeCoerce(0x7ac3c0, 0x0, 0x7f38c1681ea8, 0x7aca20, 0x0, ...)
        /home/manveru/.gvm/pkgsets/go1.2/global/src/github.com/bitly/go-nsq/config.go:275 +0x379
github.com/bitly/go-nsq.coerce(0x7ac2a0, 0x0, 0x7f38c1681ea8, 0x7aca20, 0xc2100c8458, ...)
        /home/manveru/.gvm/pkgsets/go1.2/global/src/github.com/bitly/go-nsq/config.go:264 +0x232
github.com/bitly/go-nsq.(*Config).Set(0xc2100c8400, 0x9436b0, 0xc, 0x7ac2a0, 0x0, ...)
        /home/manveru/.gvm/pkgsets/go1.2/global/src/github.com/bitly/go-nsq/config.go:184 +0x39f

@mreiferson
Copy link
Member

ahh, wonderful (we probably need some tests)

thanks again @manveru

mreiferson added a commit that referenced this pull request Jun 1, 2014
enable setting the max_attempts config option
@mreiferson mreiferson merged commit 013409c into nsqio:master Jun 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants