default logger #51
Merged
default logger #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another option could be to have the existing verbose flag set the default logger level, or we could move to a config flag that actually specifies the level more explicitly. |
| @@ -21,8 +21,6 @@ type Config struct { | |||
| sync.RWMutex | |||
| initOnce sync.Once | |||
|
|
|||
| verbose bool `opt:"verbose"` | |||
There was a problem hiding this comment.
remove from the various function comments?
There was a problem hiding this comment.
oops i had unsaved files i didn't get pushed up. squashed in the rest of this change.
|
yea, this is a good idea 👍 |
|
RFM |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the default logger for consumers/producers to stderr and set the default log level to info. This also removes the 'verbose' option as it was unused.
cc: @mreiferson