handle lookupd_http_address like pynsq #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
would fail if scheme was present, but path was completely blank (not even just /)
|
validated by building nsq_tail against this and testing various forms of --lookupd-http-address |
jehiah
added a commit
that referenced
this pull request
Jul 11, 2014
handle lookupd_http_address like pynsq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-nsq would set the path /lookup only if the path was
"/", but not if the path was completely empty. pynsq
would also set the path /lookup if the path was completely empty.
cc @jehiah @mreiferson