producer: fix write error deadlock #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this fix is ghetto, but alternatively we can split the transaction consumption/ RFR @jehiah |
|
would making ioErrorChan a buffered channel be a better option? |
|
Got it i see the deadlock with router which could trigger that IOError. Should the producer router() also |
if `WriteCommand` fails, since it only occurs inside the same goroutine that receives `Delegate` events, the call to `WriteCommand` deadlocks trying to delegate the `IOError` (which sends to `Producer.ioErrorChan`) fix it by just closing inline
|
alright, even better... RFR |
jehiah
added a commit
that referenced
this pull request
Jul 20, 2014
producer: fix write error deadlock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit message, fixes nsqio/nsq#408