config should accept tls-client-cert #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RFR @jehiah |
| } | ||
|
|
||
| func (t *tlsConfig) HandlesOption(c *Config, option string) bool { | ||
| switch option { | ||
| case "tls-root-ca-file", "tls-insecure-skip-verify": | ||
| case "tls-root-ca-file", "tls-insecure-skip-verify", "tls-cert", "tls-key": |
There was a problem hiding this comment.
Can you document these in comments somewhere in the Config struct which is where we documented all the rest?
|
LGTM aside from config docs |
mreiferson
force-pushed
the
tls_opts_75
branch
from
067f71c to
870f4ff
Compare
|
updated and squished in |
jehiah
added a commit
that referenced
this pull request
Aug 21, 2014
config should accept tls-client-cert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no way to specify TLS client certificate via
Set(aka--reader-opt)