Fix client verification and wording #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -344,6 +344,7 @@ func (t *tlsConfig) Set(c *Config, option string, value interface{}) error { | |||
| return fmt.Errorf("ERROR: failed to append certificates from Certificate Authority file") | |||
| } | |||
| c.TlsConfig.ClientCAs = tlsCertPool | |||
| c.TlsConfig.RootCAs = tlsCertPool | |||
There was a problem hiding this comment.
it is always a client, regardless of being a Consumer or Producer, so I think we can just set RootCAs
Per 5429f88#commitcomment-7481700, "When the tls.Config is used for a TLS client, it should be setting c.TlsConfig.RootCAs, not .ClientCAs; otherwise there will be no possible roots to verify the server cert." Because go-nsq is always used as a client, RootCAs needs to be set, not ClientCAs. Lastly, the cert is public, not private, and the key is private, not public.
|
LGTM, thanks! |
mreiferson
added a commit
that referenced
this pull request
Aug 22, 2014
Fix client verification and wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per 5429f88#commitcomment-7481700,
"When the tls.Config is used for a TLS client, it should be setting c.TlsConfig.RootCAs,
not .ClientCAs; otherwise there will be no possible roots to verify the server cert."
Because go-nsq is always used as a client, RootCAs needs to be set, not ClientCAs.
Lastly, the cert is public, not private, and the key is private, not public.