reader: tests / centralize RDY handling #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
brace yourself... this one is RFR @jehiah |
|
🚀 nice work. I've taken a first pass at reading through the diff. I'd like to sit on this a little as it's tough to remember all the intricacies of RDY handling right away. |
|
this is a lonely pull request |
|
ROUND 2 |
This was referenced Oct 18, 2013
Closed
* consolidate RDY handling to a single goroutine per Reader instead of per connection. this simplifies the code paths and eliminates the need to synchronize across connections. (ie. when you encounter backoff you want all of the connections for that Reader to backoff). * when exiting backoff send RDY 1 to single, random, connection. * improve redistribution to better detect and handle cases where disconnections need their orphaned RDY count transferred to existing connections, such as when in backoff.
* trim long lines * separate files for nsqConn and Reader * comment cleanup
jphines
pushed a commit
that referenced
this pull request
Oct 21, 2013
reader: tests / centralize RDY handling
amosir
pushed a commit
to amosir/go-nsq
that referenced
this pull request
Jan 16, 2024
write to next file if writePos == maxBytesPerFile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds better test coverage for backoff and recovery and refactors RDY handling to a single goroutine per reader rather than per connection. ping #1 cc @jehiah