Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

producer: panic on error before first connection #82

Merged
merged 1 commit into from
Sep 5, 2014

Conversation

mreiferson
Copy link
Member

from #78

goroutine 24 [running]:
runtime.panic(0x71e9c0, 0x926eb3)
    /usr/local/go/src/pkg/runtime/panic.c:279 +0xf5
github.com/bitly/go-nsq.(*Conn).Close(0x0, 0x0, 0x0)
    /mnt/hgfs/twmb/dev/go/src/github.com/bitly/go-nsq/conn.go:175 +0xcb
github.com/bitly/go-nsq.(*Producer).close(0xc208102000)
    /mnt/hgfs/twmb/dev/go/src/github.com/bitly/go-nsq/producer.go:239 +0x88
github.com/bitly/go-nsq.(*Producer).onConnIOError(0xc208102000, 0xc2080bcd80, 0x7f13c7b59da0, 0xc208100240)
    /mnt/hgfs/twmb/dev/go/src/github.com/bitly/go-nsq/producer.go:327 +0x27
github.com/bitly/go-nsq.(*producerConnDelegate).OnIOError(0xc208032138, 0xc2080bcd80, 0x7f13c7b59da0, 0xc208100240)
    /mnt/hgfs/twmb/dev/go/src/github.com/bitly/go-nsq/delegates.go:141 +0x48
github.com/bitly/go-nsq.(*Conn).WriteCommand(0xc2080bcd80, 0xc2080d1c70, 0x0, 0x0)
    /mnt/hgfs/twmb/dev/go/src/github.com/bitly/go-nsq/conn.go:254 +0x1e7
github.com/bitly/go-nsq.(*Conn).identify(0xc2080bcd80, 0x920248, 0x0, 0x0)
    /mnt/hgfs/twmb/dev/go/src/github.com/bitly/go-nsq/conn.go:293 +0xa1e
github.com/bitly/go-nsq.(*Conn).Connect(0xc2080bcd80, 0x9, 0x0, 0x0)
    /mnt/hgfs/twmb/dev/go/src/github.com/bitly/go-nsq/conn.go:149 +0x346
github.com/bitly/go-nsq.(*Producer).connect(0xc208102000, 0x0, 0x0)
    /mnt/hgfs/twmb/dev/go/src/github.com/bitly/go-nsq/producer.go:220 +0x3f4
github.com/bitly/go-nsq.(*Producer).sendCommandAsync(0xc208102000, 0xc2080d1b30, 0xc20811bc80, 0x0, 0x0, 0x0, 0x0, 0x0)
    /mnt/hgfs/twmb/dev/go/src/github.com/bitly/go-nsq/producer.go:182 +0xd7
github.com/bitly/go-nsq.(*Producer).sendCommand(0xc208102000, 0xc2080d1b30, 0x0, 0x0)
    /mnt/hgfs/twmb/dev/go/src/github.com/bitly/go-nsq/producer.go:165 +0x78
github.com/bitly/go-nsq.(*Producer).Publish(0xc208102000, 0x778bd0, 0x9, 0xc2080bca20, 0x105, 0x116, 0x0, 0x0)
    /mnt/hgfs/twmb/dev/go/src/github.com/bitly/go-nsq/producer.go:150 +0x16f

@mreiferson mreiferson added the bug label Sep 3, 2014
@mreiferson
Copy link
Member Author

RFR @jehiah

jehiah added a commit that referenced this pull request Sep 5, 2014
producer: panic on error before first connection
@jehiah jehiah merged commit 36d6844 into nsqio:master Sep 5, 2014
@mreiferson mreiferson deleted the producer_panic_82 branch September 6, 2014 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants