Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various improvements #89

Merged
merged 2 commits into from
Nov 7, 2014
Merged

various improvements #89

merged 2 commits into from
Nov 7, 2014

Conversation

mreiferson
Copy link
Member

  • add source string to Message so that consumers can use that information
  • clean up some spammy logging
  • reduce garbage

@mreiferson
Copy link
Member Author

RFR

@mreiferson mreiferson mentioned this pull request Oct 30, 2014
Closed
@mreiferson
Copy link
Member Author

I should probably explain why I added the Source struct var... I needed a way to segment aggregated messages by their source nsqd so that I could respond to aggregated messages in parallel groups based on said source.

@jehiah if you have any ideas for a better way to expose this information I'm all ears.

@mreiferson
Copy link
Member Author

FYI moved "source" changes to #92

jehiah added a commit that referenced this pull request Nov 7, 2014
@jehiah
Merge pull request #89 from mreiferson/debug_89
6e0548d 
various improvements
@jehiah jehiah merged commit 6e0548d into nsqio:master Nov 7, 2014
@mreiferson mreiferson deleted the debug_89 branch November 7, 2014 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mreiferson @jehiah