consumer: ability to disconnect from nsqd #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -477,8 +483,6 @@ func (r *Consumer) ConnectToNSQD(addr string) error { | |||
| conn.Close() | |||
| } | |||
|
|
|||
| r.pendingConnections[addr] = true | |||
There was a problem hiding this comment.
I could have separated these commits better, but this was racey and needed to be moved into the critical section inside the lock.
|
I'm going to add mirroring functionality to remove |
mreiferson
referenced
this pull request
in hailocab/go-nsq
Nov 2, 2014
|
RFR @jehiah |
|
|
||
| idx := indexOf(addr, r.nsqdTCPAddrs) | ||
| if idx == -1 { | ||
| return errors.New(fmt.Sprintf("unknown nsqd TCP address %s", addr)) |
There was a problem hiding this comment.
mixed feelings as to weather or not this should error since we don't expose the list of where you are connected to. We don't typically expose named errors, but perhaps this would be a fair spot for return NotConnectedError.
There was a problem hiding this comment.
NotConnectedError seems good to me
|
updated |
|
same for |
|
looks good; squash beyond that |
|
Yes, they're consistent now |
mreiferson
force-pushed
the
remove_addrs_91
branch
from
cd8e94f to
ed86be0
Compare
|
🔨 |
jehiah
added a commit
that referenced
this pull request
Nov 6, 2014
consumer: ability to disconnect from nsqd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a function that allows the end-user to remove
addresses from the list of
nsqdfor situations wherethey're not using
nsqlookupdand instead maintainingtheir own list.