tests: switch from Travis-CI to GitHub Actions for CI #247
Conversation
ploxiln
force-pushed
the
github_actions_ci
branch
from
d380369 to
8b291d4
Compare
|
hmm... I copied this from my own repos, where just adding this yml file in this dir seemed to kick it off ... but now it's not doing anything ... |
ploxiln
force-pushed
the
github_actions_ci
branch
from
8b291d4 to
3b0296e
Compare
|
I think it's because the branch which introduces it must be in this repo |
|
huh it's working here now? |
ploxiln
force-pushed
the
github_actions_ci
branch
3 times, most recently
from
0e188f9 to
367685c
Compare
|
GitHub Actions does not have an "include just these combos" feature like we used with Travis-CI, it only has an "exclude these combos" setting. But it gives lots of parallel instances so it's pretty fast even with a huge matrix. (The max is ~255.) The effective test matrix is updated:
You don't have to use a container with GitHub Actions, you can just ask for a particular version of python and get a workable environment straight on the VM. But I'm a bit worried about how fast github removes support for older python versions, e.g. python-3.4 was removed late last year, and can no longer be used. So I use public/official containers on DockerHub which I expect will continue to exist for years even if no longer updated. (I have tested with a python-3.4 container in one of my own projects, but it's based on debian-9 stretch instead of debian-10 buster, and I figured it wasn't quite worth the mess here.) If you want me to add older tornado or python-3.4 let me know :) cc @jehiah |
ploxiln
force-pushed
the
github_actions_ci
branch
2 times, most recently
from
6391551 to
67c5936
Compare
|
... updated the strategy: include all python versions in test matrix, but do not include nsqd versions in test matrix, instead pick nsqd version based on python version |
|
Should we land this @ploxiln? |
|
I've been on a trip since friday, will be back a bit on sunday, but fully on monday. I'll make sure this is up-to-date and run it again before merge. |
|
SGTM |
because Travis-CI no longer updates commit status reliably for the travis-ci.org integration
ploxiln
force-pushed
the
github_actions_ci
branch
from
67c5936 to
600e27c
Compare
| case "$PY_VER" in | ||
| '(3, 4)' | '(3, 7)' ) NSQ_DIST="nsq-1.0.0-compat.linux-amd64.go1.8" ;; | ||
| '(2, 7)' | '(3, 6)' ) NSQ_DIST="nsq-1.1.0.linux-amd64.go1.10.3" ;; | ||
| '(3, 5)' | '(3, 8)' ) NSQ_DIST="nsq-1.2.0.linux-amd64.go1.12.9" ;; |
There was a problem hiding this comment.
notice my weird scheme to reduce the text matrix by correlating version of python and version of nsqd
There was a problem hiding this comment.
I did notice that, I resisted commenting 😁
|
updated |
|
I guess we should follow up with |
because Travis-CI no longer updates commit status reliably for the travis-ci.org integration (though it does seem to be working on this repo for now? I've seen it stop working on a bunch of my own, and also nsqio/go-nsq#294 and nsqio/go-diskqueue#15)
(and because GitHub is has lots of money for free CI servers, so they are a bit more available and reliable)