nsqd Authentication Support #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RFR here @mreiferson |
| @@ -270,6 +277,7 @@ def _on_identify_response(self, data, **kwargs): | |||
| self.off('response', self._on_identify_response) | |||
|
|
|||
| if data == 'OK': | |||
| logging.waring('nsqd version does not support feature netgotiation') | |||
|
the rest LGTM, but I still think we should finalize |
| @@ -287,6 +297,9 @@ def _on_identify_response(self, data, **kwargs): | |||
| self._features_to_enable.append('tls_v1') | |||
| if self.snappy and data.get('snappy'): | |||
| self._features_to_enable.append('snappy') | |||
|
|
|||
| if data.get('auth_required'): | |||
| self._authentication_required = True | |||
There was a problem hiding this comment.
these two lines can be simplified to self._authentication_required = data.get('auth_required', False)
|
naming suggestion applies here too, I think we should just run with |
|
merge me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to go along with nsqio/nsq#356 and support Authentication in the client library
cc: @mreiferson