Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move configuration to PHP #52

Merged
merged 1 commit into from
Jul 4, 2020
Merged

Move configuration to PHP #52

merged 1 commit into from
Jul 4, 2020

Conversation

core23
Copy link
Member

@core23 core23 commented Jul 4, 2020

Subject

Allow loading services without XML extension.

@codecov
Copy link

codecov bot commented Jul 4, 2020

Codecov Report

Merging #52 into main will increase coverage by 0.56%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #52      +/-   ##
============================================
+ Coverage     98.51%   99.08%   +0.56%     
  Complexity       46       46              
============================================
  Files            10       12       +2     
  Lines           135      218      +83     
============================================
+ Hits            133      216      +83     
  Misses            2        2              
Impacted Files Coverage Δ Complexity Δ
src/DependencyInjection/NucleosLastFmExtension.php 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
src/Resources/config/action.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)
src/Resources/config/services.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32dcd15...6dc2d73. Read the comment docs.

@kodiakhq kodiakhq bot merged commit 9f7f4dc into main Jul 4, 2020
@core23 core23 deleted the php-files branch July 4, 2020 12:30
@core23 core23 added this to the 1.0.0 milestone Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant