Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: type the icon prop to improve DX #1481

Merged
merged 1 commit into from
Nov 25, 2024
Merged

feat: type the icon prop to improve DX #1481

merged 1 commit into from
Nov 25, 2024
+19 −19

Conversation

haideralsh
Copy link
Contributor

Description

Fixes: #1438

Changes include

  • breaking change: a change that is not backwards-compatible and/or changes current functionality
  • fix: a non-breaking change that solves an issue
  • feature: a non-breaking change that adds functionality
  • chore: contains no changes affecting the library, such as documentation or test updates

Feature checklist

  • Appropriate tests have been added
  • Documentation has been updated
  • Accessibility has been considered

@haideralsh haideralsh merged commit 4f215fa into master Nov 25, 2024
4 checks passed
@haideralsh haideralsh deleted the type-icon-prop branch November 25, 2024 18:33
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 10.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@nulogy/icons missing types
1 participant
@haideralsh