Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI post capture delete #434

Merged
merged 14 commits into from
Jan 5, 2021
Merged

UI post capture delete #434

merged 14 commits into from
Jan 5, 2021

Conversation

CS6
Copy link
Contributor

@CS6 CS6 commented Jan 4, 2021 •
edited
Loading

add delete ui
image

@CS6 CS6 requested a review from seanwu1105 January 4, 2021 10:26
@CS6 CS6 marked this pull request as ready for review January 4, 2021 10:28
@CS6 CS6 changed the base branch from develop to uiux January 4, 2021 11:20
@seanwu1105 seanwu1105 changed the base branch from uiux to develop January 4, 2021 12:34
@seanwu1105 seanwu1105 changed the base branch from develop to uiux January 4, 2021 12:34
@CS6 CS6 requested a review from seanwu1105 January 5, 2021 07:56
seanwu1105
seanwu1105 previously requested changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@seanwu1105 seanwu1105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the last bit of formatting problem and this PR is good to merge.

src/app/pages/home/asset/options-menu/options-menu.component.ts Show resolved Hide resolved
src/app/pages/home/asset/options-menu/options-menu.component.ts Show resolved Hide resolved
@seanwu1105 seanwu1105 dismissed their stale review January 5, 2021 08:23

Outdated request.

@seanwu1105 seanwu1105 self-requested a review January 5, 2021 08:23
@CS6 CS6 requested a review from seanwu1105 January 5, 2021 09:33
@CS6 CS6 requested a review from seanwu1105 January 5, 2021 10:56
@seanwu1105 seanwu1105 merged commit b468686 into uiux Jan 5, 2021
@seanwu1105 seanwu1105 deleted the UI-PostCapture-delete branch January 5, 2021 11:02
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanwu1105 seanwu1105 Awaiting requested review from seanwu1105

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CS6 @seanwu1105