Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some https URLs clickable #241

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Make some https URLs clickable #241

merged 4 commits into from
Jan 7, 2025

Conversation

star1327p
Copy link
Contributor

@star1327p star1327p commented Jan 5, 2025

Make some https URLs clickable by adding < and > around the link.

Copy link
Contributor

@Mukulikaa Mukulikaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this, @star1327p. I left some minor suggestions.

content/tutorial-nlp-from-scratch.md Outdated Show resolved Hide resolved
content/tutorial-nlp-from-scratch.md Outdated Show resolved Hide resolved
@star1327p
Copy link
Contributor Author

@Mukulikaa Thank you for your review! I have added the changes to this PR.

@star1327p
Copy link
Contributor Author

@bsipocz I rechecked the commits and updated two more urls based on your suggestions.

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Mukulikaa Mukulikaa merged commit 552fcd0 into numpy:main Jan 7, 2025
12 checks passed
@Mukulikaa
Copy link
Contributor

Thanks @star1327p.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants