Revert "add HTML formatter" (#569)

nunomaduro · Mar 8, 2022 · 5e84dab · 5e84dab · erick-jeronimo · May 28, 2022
1 parent 889f10c
commit 5e84dab
Show file tree

Hide file tree

Showing 10 changed files with 2 additions and 2,282 deletions.
diff --git a/composer.json b/composer.json
@@ -46,14 +46,10 @@
         "phpunit/phpunit": "^8.0|^9.0",
         "rector/rector": "0.11.56",
         "symfony/var-dumper": "^4.2|^5.0|^6.0",
-        "roave/no-floaters": "^1.1",
-        "symplify/easy-coding-standard": "^6.0",
-        "thecodingmachine/phpstan-strict-rules": "^0.11.0",
-        "twig/twig": "^2.0"
+        "thecodingmachine/phpstan-strict-rules": "^0.12.0"
     },
     "suggest": {
-        "ext-simplexml": "It is needed for the checkstyle formatter",
-        "twig/twig": "Twig:^2.0 is needed to support the HTML formattter"
+        "ext-simplexml": "It is needed for the checkstyle formatter"
     },
     "autoload-dev": {
         "psr-4": {

diff --git a/dashboard.html b/dashboard.html
diff --git a/docs/get-started.md b/docs/get-started.md
@@ -133,26 +133,18 @@ For changing the output format you can add the `format` flag. The following form
 - console
 - json
 - checkstyle
-- html
 
 ```bash
 ./vendor/bin/phpinsights analyse --format=json
 ```
 
-::: Twig for HTML
-The HTML formatter requires Twig to render.
-So you have to add it do your dependencies if you want to use it.
-`composer require --dev twig/twig: ^2.0`
-:::
-
 ## Saving output to file
 
 You can pipe the result to a file or to anywhere you like.
 A common use case is parsing the output formatted as json to a json file.
 
 ```bash
 ./vendor/bin/phpinsights analyse --format=json > test.json
-./vendor/bin/phpinsights analyse --format=html > test.html
 ```
 
 When piping the result remember to add the no interaction flag `-n`, as the part where you need to interact is also getting piped. (the json format does not have any interaction)

diff --git a/phpstan.neon b/phpstan.neon
@@ -25,7 +25,6 @@ parameters:
         - '#Access to an undefined property PHP_CodeSniffer\\Sniffs\\Sniff::\$#'
         - '#NunoMaduro\\PhpInsights\\Application\\Console\\Formatters\\Json has an unused parameter \$input#'
         - '#NunoMaduro\\PhpInsights\\Application\\Console\\Formatters\\Checkstyle has an unused parameter \$input#'
-        - '#NunoMaduro\\PhpInsights\\Application\\Console\\Formatters\\Html has an unused parameter \$input#'
         - '#In method "NunoMaduro\\PhpInsights\\Domain\\File::process", caught "Throwable" must be rethrown#'
         - '#In method "NunoMaduro\\PhpInsights\\Domain\\FileProcessors\\FixerFileProcessor::processFile", caught "Throwable" must be rethrown#'
         - '#Empty catch block. If you are sure this is meant to be empty, please add a "// @ignoreException" comment in the catch block.#'

diff --git a/src/Application/Console/Formatters/FormatResolver.php b/src/Application/Console/Formatters/FormatResolver.php
@@ -20,7 +20,6 @@ final class FormatResolver
         'checkstyle' => Checkstyle::class,
         'github-action' => GithubAction::class,
         'codeclimate' => CodeClimate::class,
-        'html' => Html::class,
     ];
 
     public static function resolve(

diff --git a/src/Application/Console/Formatters/Html.php b/src/Application/Console/Formatters/Html.php
diff --git a/src/Domain/Insights/InsightCollection.php b/src/Domain/Insights/InsightCollection.php
@@ -38,14 +38,6 @@ public function getCollector(): Collector
         return $this->collector;
     }
 
-    /**
-     * @return array<string, array<\NunoMaduro\PhpInsights\Domain\Contracts\Insight>>
-     */
-    public function getInsightsPerMetric(): array
-    {
-        return $this->insightsPerMetric;
-    }
-
     /**
      * Gets all insights.
      *

diff --git a/views/dashboard.html.twig b/views/dashboard.html.twig
diff --git a/views/partials/insights_per_metric.html.twig b/views/partials/insights_per_metric.html.twig
diff --git a/views/partials/stats_per_metric.html.twig b/views/partials/stats_per_metric.html.twig