fix exclude ForbiddenGlobals sniff (#562)

nunomaduro · Mar 8, 2022 · bbcc738 · bbcc738
1 parent fb676aa
commit bbcc738
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 5 deletions.
diff --git a/src/Domain/Insights/ForbiddenGlobals.php b/src/Domain/Insights/ForbiddenGlobals.php
@@ -30,7 +30,8 @@ public function getDetails(): array
         $details = [];
 
         foreach ($this->collector->getGlobalVariableAccesses() as $file => $global) {
-            if ($this->shouldSkipFile($file)) {
+            $filePath = current(explode(':', $file));
+            if ($this->shouldSkipFile($filePath)) {
                 continue;
             }
 

diff --git a/tests/Domain/Insights/ForbiddenGlobalsTest.php b/tests/Domain/Insights/ForbiddenGlobalsTest.php
@@ -5,13 +5,14 @@
 namespace Tests\Domain\Insights;
 
 use NunoMaduro\PhpInsights\Application\Console\Formatters\PathShortener;
-use PHPUnit\Framework\TestCase;
 use NunoMaduro\PhpInsights\Domain\Insights\ForbiddenGlobals;
 use NunoMaduro\PhpInsights\Domain\Analyser;
+use NunoMaduro\PhpInsights\Domain\Metrics\Code\Classes;
+use Tests\TestCase;
 
 final class ForbiddenGlobalsTest extends TestCase
 {
-    public function testFileHasNoGlobals() : void
+    public function testFileHasNoGlobals(): void
     {
         $files = [
             __DIR__ . '/Fixtures/LittleToComplexClass.php',
@@ -27,7 +28,7 @@ public function testFileHasNoGlobals() : void
         self::assertEmpty($insight->getDetails());
     }
 
-    public function testHasOneGlobalUsage() : void
+    public function testHasOneGlobalUsage(): void
     {
         $files = [
             __DIR__ . '/Fixtures/FileWithGlobals.php',
@@ -50,7 +51,7 @@ public function testHasOneGlobalUsage() : void
         self::assertEquals('FileWithGlobals.php:3', $file);
     }
 
-    public function testHasMultipleGlobalsUsage() : void
+    public function testHasMultipleGlobalsUsage(): void
     {
         $files = [
             __DIR__ . '/Fixtures/FileWithMultipleGlobals.php',
@@ -72,4 +73,34 @@ public function testHasMultipleGlobalsUsage() : void
         $file = PathShortener::fileName($detail, $commonPath);
         self::assertEquals('FileWithMultipleGlobals.php:3', $file);
     }
+
+    public function testSkipFile(): void
+    {
+        $file = __DIR__ . '/Fixtures/FileWithMultipleGlobals.php';
+
+        $collection = $this->runAnalyserOnConfig(
+            [
+                'add' => [
+                    Classes::class => [
+                        ForbiddenGlobals::class,
+                    ],
+                ],
+                'config' => [
+                    ForbiddenGlobals::class => [
+                        'exclude' => [$file],
+                    ],
+                ],
+            ],
+            [$file]
+        );
+
+        $errors = 0;
+        foreach ($collection->allFrom(new Classes()) as $insight) {
+            if ($insight->getInsightClass() === ForbiddenGlobals::class && $insight->hasIssue()) {
+                $errors++;
+            }
+        }
+
+        self::assertEquals(0, $errors);
+    }
 }