Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHPStan wrapper #165

Open
nunomaduro opened this issue Jun 5, 2019 · 1 comment
Open

Add PHPStan wrapper #165

nunomaduro opened this issue Jun 5, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@nunomaduro
Copy link
Owner

Q A
Bug report? no
Feature request? yes
Library version 1.6.0

Add PHPStan wrapper just like we did on with PHPCS: https://github.com/nunomaduro/phpinsights/blob/master/src/Domain/Insights/InsightFactory.php.

Note that: I don't want false positives on PHP Insights, so we only want to incorporate rules that are 100% accurate.

@nunomaduro nunomaduro added the enhancement New feature or request label Jun 5, 2019
This was referenced Jul 5, 2019
@nunomaduro nunomaduro mentioned this issue Oct 24, 2019
6 tasks
@olivernybroe
Copy link
Collaborator

Alright, so after I tried adding support for phpstan I ran into multiple issues and backwards compatibility things.
I think we if should add support for phpstan we have to do it by running their tool directly, not hacking into their tool.

However, phpstan's errors are missing which rule the error came from phpstan/phpstan#3065.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants