[OnHold|Feat] Add PhpStan #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat-phpstan # Conflicts: # src/Domain/Insights/InsightFactory.php
This class is responsible for running the sniffs and rules from phpcs and phpstan
|
This will be huge. |
…into feat-phpstan
Removed the usage of ECS container: We now handle the file processors ourself in the runner class Added more phpstan rules: We now use a lot more rules from phpstan Fixed a bug with non autoloaded files: Files which is not part of the autoload did not work with phpstan. Removed the need for phpstan analyser: We now only use the parser, this improves the speed a lot Merged sniff insight and sniff decorator together: The sniff insights and decorator are now 1 class instead of two Removed errorAndDiffCollector: We don't use the collector anymore. We now store the sniff errors inside the sniff itself.
|
This latest commit is a rather large refactoring. It makes some gigantic changes to the whole structure of how we run everything. (Sorry that this PR is getting out of the scope for adding phpstan only) |
|
Closing this PR as there is soo many changes since I made this that it's probably quicker to start over... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for phpstan.
It takes the same approach as the sniffers and actually uses the same file processor class.
The PR is based off the new formatter branch #201, as I didn't want to implement the
HasDetailsinterface twice. So it is on hold until the formatter branch is merged in.InsightFactoryis required, as the naming in there and so on is kinda random now, as it also handles rules from phpstan and not only sniffs.RuleDecoratorclass.resolves: #165