Distribute through phive

[szepeviktor]

in a PHAR file phpinsights would not conflict with the project's deps

https://github.com/phar-io/phive

[nunomaduro]

No plans at the moment.

[szepeviktor]

@nunomaduro I'm very sad.

Modern PHP tools tend to go PHAR-only, e.g. PHPStan

There would be only these steps:

• add 1 phive config
• release process: add a phar file
• release process: add a GPG signature

What do you think?

[nunomaduro]

It’s a good idea. It’s just I don’t have plans to do it in the next weeks. Let’s reconsider this.

…

On Wed 8 May 2019 at 03:49, Viktor Szépe ***@***.***> wrote: @nunomaduro <https://github.com/nunomaduro> I'm very sad. Modern PHP tools *tend* to go PHAR-only, e.g. PHPStan There would be only these steps: - add 1 phive config - release process: add a phar file - release process: add a GPG signature What do you think? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABJUKVDGWVS4DRPEBTK33WLPUIWTHANCNFSM4HCZ65GQ> .

[mihai-stancu]

@nunomaduro regarding the help wanted tag, I'm guessing this would mean implementing the necessary configuration for humbug/box building the phar itself, signing it and implementing the necessary phive configuration?

Do you forsee anything else? Automated build steps to be added? The signature would still need your manual input as far as I can imagine.

I haven't done this before but i'd give it a shot.

[szepeviktor]

@mihai-stancu If you get Box working I'll add the rest.

[mihai-stancu]

Conundrum:

• php-scoper moves every class into a unique namespace
• ./your-project/phpinsights.php -- (the configuration file) references the original class names to add / remove metrics and sniffs et.al..

./your-project/phpinsights.php isn't a file you can patch at box compile time, it needs to be. patched at runtime to work.

[szepeviktor]

Why do we need php-scoper?

[mihai-stancu]

I noticed that the project uses Reflection in a few places.
Reflection loads the class via autoloader before it's parsed.
We could have class name collisions if the autoloader loads the same class name as an internal name from inside the PHAR.

[nunomaduro]

Let's re-open this issue, eventually if someone decides to work on this.

[JoyceBabu]

Let's re-open this issue, eventually if someone decides to work on this.

@nunomaduro Did you really intend to close this?