Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #10

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Fix typo #10

merged 1 commit into from
Apr 9, 2019

Conversation

seriquynh
Copy link
Contributor

@seriquynh seriquynh commented Apr 9, 2019

"software" is an uncountable noun, so "an open-sourced software" is incorrect. I just help to fix it.
https://www.oxfordlearnersdictionaries.com/definition/english/software?q=software

There are some trailing spaces that are removed automatically by my editor on saving.

@szepeviktor
Copy link
Contributor

and maybe "open-source" without the d

@seriquynh
Copy link
Contributor Author

seriquynh commented Apr 9, 2019

In this situation, I guess both open and sourced are used as adjectives. Let's visit laravel/framework. Mr.Otwell - the creator of Laravel is American.

@nunomaduro nunomaduro merged commit c1fc313 into nunomaduro:feat/first Apr 9, 2019
@nunomaduro
Copy link
Owner

Thanks @XuanQuynh, I would love to get more contributions from you. 🥳

@szepeviktor
Copy link
Contributor

@seriquynh seriquynh deleted the fix_typo branch April 9, 2019 08:31
@seriquynh
Copy link
Contributor Author

@nunomaduro I am following you on github and twitter. I will support whenever I can. Thanks for creating awesome open-sourced packages!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants