forked from se-edu/addressbook-level1
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[T2A3][T02-A1]Haya Alsharef #597
Open
hayaz3
wants to merge
25
commits into
nus-cs2103-AY1617S1:master
Choose a base branch
from
hayaz3:T2A3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exist on windows. (#23)
* Update user guide to reflect the new implementation of isValidFilePath. * Fix formatting error for changing save location in user guide. * Fix formatting error for changing save location in user guide. * Fix formatting error for changing save location in user guide. Fix formatting error for changing save location in user guide. Fix formatting for user guide change save location. * Slight edit for user guide on changing the save location. * Improve clarity of 'regular' file. * Update regular file explanation.
Change 2: executeCommand method: amend all final type variable names to follow the standard form Change 3: executeCommand method: refract to create specifyCommand method Change 4: splitCommandWordAndArgs method: amend all final type variable names to follow the standard form Change 5: executeAddPerson method: amend all final type variable names to follow the standard form Change 6: executeFindPersons method: amend all final type variable names to follow the standard form Change 7: getDisplayString method: refract to create formulateDisplayString method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review