[T2A2][W15-A3]Sriram Sami #90
Conversation
|
Ready for review. |
| @@ -365,7 +365,8 @@ public static String executeCommand(String userInputString) { | |||
| */ | |||
| private static String[] splitCommandWordAndArgs(String rawUserInput) { | |||
| final String[] split = rawUserInput.trim().split("\\s+", 2); | |||
There was a problem hiding this comment.
split is not a particularly good variable name; you could have changed it to be more reflective of what it is
in any case, its an array, so by the standards, it should have been splits :-P
|
|
Thanks for the comments! Much appreciated. Apologies - I just saw this. |
|
welcome! your ACK came in late ;-) On Thu, Sep 8, 2016 at 10:43 PM, Sriram Sami [email protected]
|
|
please close the PR if you haven't done yet. On Thu, Sep 8, 2016 at 10:43 PM, Sriram Sami [email protected]
|
|
Yep I think it's closed already |
…-AY1617S1#90) The default storage file 'addressbook.txt' is not provided by default. The program has to create a new storage file, and this process is written in the program's log. Due to the additional information in the log, the first test run after cloning the master always result in failure, as the additional information creates a difference between actual.txt and expected.txt, causing the test to fail. Let's add the default storage file 'addressbook.txt' into the test folder so that the runtests.bat will stop failing on first run.
No description provided.