Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brotli support removed #276

Open
Francois-Francois opened this issue Aug 19, 2019 · 4 comments · Fixed by titonobre/fanweekend.pt#17 or titonobre/fanweekend.pt#19
Open

Brotli support removed #276

Francois-Francois opened this issue Aug 19, 2019 · 4 comments · Fixed by titonobre/fanweekend.pt#17 or titonobre/fanweekend.pt#19

Comments

@Francois-Francois
Copy link

What problem does this feature solve?

In the past, Brotli was not supported on nodejs servers.

If I understand correctly, this is now supported since a few months : nodejs/node#20458

This PR dropped support for Brotli : #180

Maybe it's time to revert this BR because Axios is supporting it too : axios/axios#2071

What does the proposed changes look like?

Revert this PR #180

This feature request is available on Nuxt community (#c270)
@ghost ghost added the cmty:feature-request label Aug 19, 2019
@TheAlexLichter
Copy link
Member

Reverting isn't enough as Brotli isn't supported in all version. One would have to do a check like in axios/axios#2071

Other than that, I absolutely agree.

@Francois-Francois Francois-Francois changed the title Brolti support removed Brotli support removed Aug 19, 2019
@pi0
Copy link
Member

pi0 commented Apr 21, 2020

Thanks @Rikless for report.

@pi0 pi0 closed this as completed in 074f98c Apr 21, 2020
@ITJesse
Copy link

ITJesse commented Apr 22, 2020

As the axios is not support brotli now, you should drop server side Brotli support at this time.

@ITJesse
Copy link

ITJesse commented Apr 22, 2020

I recommend revet this commit:
074f98c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants