-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brotli support removed #276
Open
Francois-Francois opened this issue
Aug 19, 2019
· 4 comments
· Fixed by titonobre/fanweekend.pt#17 or titonobre/fanweekend.pt#19
Open
Brotli support removed #276
Francois-Francois opened this issue
Aug 19, 2019
· 4 comments
· Fixed by titonobre/fanweekend.pt#17 or titonobre/fanweekend.pt#19
Comments
ghost
added
the
cmty:feature-request
label
Aug 19, 2019
Reverting isn't enough as Brotli isn't supported in all version. One would have to do a check like in axios/axios#2071 Other than that, I absolutely agree. |
Thanks @Rikless for report. |
As the axios is not support brotli now, you should drop server side Brotli support at this time. |
I recommend revet this commit: |
ITJesse
added a commit
to ITJesse/axios-module
that referenced
this issue
Apr 22, 2020
…community#276)" This reverts commit 074f98c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What problem does this feature solve?
In the past, Brotli was not supported on nodejs servers.
If I understand correctly, this is now supported since a few months : nodejs/node#20458
This PR dropped support for Brotli : #180
Maybe it's time to revert this BR because Axios is supporting it too : axios/axios#2071
What does the proposed changes look like?
Revert this PR #180
The text was updated successfully, but these errors were encountered: