Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow quiet operation in disabled mode #39

Closed
rchl opened this issue Jun 8, 2020 · 2 comments · Fixed by #61
Closed

Allow quiet operation in disabled mode #39

rchl opened this issue Jun 8, 2020 · 2 comments · Fixed by #61

Comments

@rchl
Copy link
Member

rchl commented Jun 8, 2020 •
edited
Loading

With ec85699 the mocked instance is logging all navigation events. While I appreciate the mocked instance, I don't really want to see the logs in development. Maybe that should be controlled by a new debug option?
@pi0
Copy link
Member

pi0 commented Jun 8, 2020

Hi @rchl i can see. Would you be interested in adding option for it? Even disabled by default seems good to me :)

@rchl
Copy link
Member Author

rchl commented Jun 8, 2020 •
edited
Loading

I could work on it when I have some time but the more I think about it, the less sure I am how this should be fixed.

So adding debug option to log pushes IMO makes sense but then it also makes sense that it works whether using normal or mock variant. So the mock instance, if enabled, would just do nothing on calling the methods and there would be a separate plugin just for handling logging when debug is enabled. Does that sound good to you?

rchl added a commit to rchl/gtm-module that referenced this issue Jul 29, 2020
@rchl
fix(plugin): add "debug" option to toggle logging and disable by default
eddbe65 
A new "debug" option for toggling whether $gtm API calls are logged to
the console. Also changes default behavior to not log anything.

Resolves nuxt-community#39
@rchl rchl mentioned this issue Jul 29, 2020
Merged
@pi0 pi0 closed this as completed in #61 Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(plugin): add debug option and disable by default rchl/gtm-module
2 participants
@rchl @pi0