Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lastmod regex issue #211

Merged
merged 3 commits into from
Jan 14, 2024
Merged

fix: lastmod regex issue #211

merged 3 commits into from
Jan 14, 2024

Conversation

PabloGBarcelo
Copy link
Contributor

@PabloGBarcelo PabloGBarcelo commented Jan 13, 2024 •
edited
Loading

Pull Request Description

This Pull Request addresses the regex to comply with W3C specifications and adjusts the lastmod format in the sitemap file to adhere to W3C conventions.

Proposed Changes

Regex

  • Corrected the regex to align with W3C specifications.
  • Conducted tests to ensure the new regex works correctly in various use cases.

Compliance Check

  • [ X ] Reviewed and followed the project's contribution guidelines.
  • [ X ] Tests have passed successfully.

Issues

Tests

BEFORE

image

AFTER

image

@harlan-zw
Copy link
Collaborator

Amazing work @PabloGBarcelo 👏

@harlan-zw harlan-zw changed the title fix(lastmod): date issue fix: lastmod regex issue Jan 14, 2024
@harlan-zw harlan-zw merged commit c8ae193 into nuxt-modules:main Jan 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harlan-zw harlan-zw harlan-zw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PabloGBarcelo @harlan-zw