Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nuxt-i18n-micro module integration #357

Merged
merged 8 commits into from
Sep 20, 2024

Conversation

harlan-zw
Copy link
Collaborator

πŸ”— Linked issue

s00d/nuxt-i18n-micro#11

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

As the i18n config has an identical signature we can support the https://github.com/s00d/nuxt-i18n-micro module out of the box without any extra effort 🀞

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
sitemap-edge-demo βœ… Ready (Inspect) Visit Preview Sep 20, 2024 7:29am

@genu
Copy link

genu commented Sep 8, 2024

@harlan-zw
Copy link
Collaborator Author

Thanks for the review @genu, I'm only considering sitemap integration with this module at the moment.

@genu
Copy link

genu commented Sep 9, 2024

I see, but wouldn't it cause issue when using the main seo module?

For instance, it will polyfill the i18n composable when it should not, since its provided by nuxt-i18n-micro.

Nuxt throws errors about duplicate composables when using together.

@harlan-zw
Copy link
Collaborator Author

Hmm good point but it's a warning that is thrown so not a big deal, the pollyfills should be registered with low priority though.

Having to support nuxt-i18n-micro in all SEO modules is not something I have capacity for at the moment so if this is a blocker then we may consider closing this PR.

@genu
Copy link

genu commented Sep 9, 2024

Hmm, I can test a little bit more on my end, as I noticed the polyfill is indeed used instead of the i18n-micro composable.

Maybe the order in the modules array affects this? πŸ€”

@harlan-zw harlan-zw merged commit 39b917c into main Sep 20, 2024
2 checks passed
@harlan-zw harlan-zw deleted the feat/nuxt-i18n-micro-integration branch September 20, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants