-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nuxt-i18n-micro
module integration
#357
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
@harlan-zw is a similar change required here? |
Thanks for the review @genu, I'm only considering sitemap integration with this module at the moment. |
I see, but wouldn't it cause issue when using the main seo module? For instance, it will polyfill the i18n composable when it should not, since its provided by Nuxt throws errors about duplicate composables when using together. |
Hmm good point but it's a warning that is thrown so not a big deal, the pollyfills should be registered with low priority though. Having to support nuxt-i18n-micro in all SEO modules is not something I have capacity for at the moment so if this is a blocker then we may consider closing this PR. |
Hmm, I can test a little bit more on my end, as I noticed the polyfill is indeed used instead of the i18n-micro composable. Maybe the order in the modules array affects this? π€ |
β¦-i18n-micro-integration
π Linked issue
s00d/nuxt-i18n-micro#11
β Type of change
π Description
As the i18n config has an identical signature we can support the https://github.com/s00d/nuxt-i18n-micro module out of the box without any extra effort π€