Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#396
β Type of change
π Description
For users relying on Nitro hooks to add new URLs they were currently limited to the
sitemap:resolved
hook.This hook mostly worked but required for end users to provide a "resolved" URL, to do so in user-land is not easy.
This PR firstly fixes it so users can add new URLs via this hook and they will get properly normalized, however this is still buggy as they are missing important resolving steps and the types will be broken.
To get around these issues, a new hook is introduced called
sitemap:input
that is called immediately after the URLs after resolved from the sources. This hook takes in "input" type URLs so that can be just a string or an object that will be fully resolved.'sitemap:input'
Type:
async (ctx: { urls: SitemapUrlInput[]; sitemapName: string }) => void | Promise<void>
{lang="ts"}Triggers once the raw list of URLs is collected from sources.
This hook is best used for inserting new URLs into the sitemap.