feat: initial support for upgrading packages in devtools #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Mar 17, 2023
| import { readPackageJSON } from 'pkg-types' | ||
| import semver from 'semver' | ||
| import { version as devToolsVersion } from '../../package.json' | ||
| import type { UpdateInfo } from '../types' | ||
| import { getPackageInfo } from 'local-pkg' |
There was a problem hiding this comment.
Would it be helpful if we expose such utility from nypm? (i also probably need it also for both CLI and layer handling dep-resolution)
There was a problem hiding this comment.
I'd be happy to! One caveat is that in local-pkg, I manually wrote the code for CJS and ESM separately, as the resolution algorithms are a bit different. Which means it can not be bundled. Not sure if we could find a better isomorphic solution, otherwise are you considering this acceptable?
There was a problem hiding this comment.
Sure. Let me check local-pkg and be back to you. Have you tried mlly.resolvePath with conditions?
antfu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.