Skip to content

Commit

Permalink
fix(InputMenu/SelectMenu): improve displayed value
Browse files Browse the repository at this point in the history
Resolves #2353
  • Loading branch information
benjamincanac committed Oct 10, 2024
1 parent 365bc0f commit 0f9ac87
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 21 deletions.
15 changes: 8 additions & 7 deletions src/runtime/components/InputMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ export interface InputMenuSlots<T> {
import { computed, ref, toRef, onMounted } from 'vue'
import { ComboboxRoot, ComboboxAnchor, ComboboxInput, ComboboxTrigger, ComboboxPortal, ComboboxContent, ComboboxViewport, ComboboxEmpty, ComboboxGroup, ComboboxLabel, ComboboxSeparator, ComboboxItem, ComboboxItemIndicator, TagsInputRoot, TagsInputItem, TagsInputItemText, TagsInputItemDelete, TagsInputInput, useForwardPropsEmits } from 'radix-vue'
import { defu } from 'defu'
import isEqual from 'fast-deep-equal'
import { reactivePick } from '@vueuse/core'
import { useAppConfig } from '#imports'
import { useButtonGroup } from '../composables/useButtonGroup'
Expand Down Expand Up @@ -162,12 +163,10 @@ const ui = computed(() => inputMenu({
buttonGroup: orientation.value
}))
function displayValue(val: AcceptableValue) {
if (typeof val === 'object') {
return val.label
}
function displayValue(value: AcceptableValue): string {
const item = items.value.find(item => props.valueKey ? isEqual(item[props.valueKey], value) : isEqual(item, value))
return val && String(val)
return item && (typeof item === 'object' ? item.label : item)
}
function filterFunction(items: ArrayOrWrapped<AcceptableValue>, searchTerm: string): ArrayOrWrapped<AcceptableValue> {
Expand All @@ -191,6 +190,8 @@ function filterFunction(items: ArrayOrWrapped<AcceptableValue>, searchTerm: stri
}
const groups = computed(() => props.items?.length ? (Array.isArray(props.items[0]) ? props.items : [props.items]) as InputMenuItem[][] : [])
// eslint-disable-next-line vue/no-dupe-keys
const items = computed(() => groups.value.flatMap(group => group) as T[])
const inputRef = ref<InstanceType<typeof ComboboxInput> | null>(null)
Expand Down Expand Up @@ -264,7 +265,7 @@ defineExpose({
<TagsInputItem v-for="(item, index) in tags" :key="index" :value="(item as string)" :class="ui.tagsItem({ class: props.ui?.tagsItem })">
<TagsInputItemText :class="ui.tagsItemText({ class: props.ui?.tagsItemText })">
<slot name="tags-item-text" :item="(item as T)" :index="index">
{{ typeof item === 'object' ? item.label : item }}
{{ displayValue(item as T) }}
</slot>
</TagsInputItemText>

Expand Down Expand Up @@ -351,7 +352,7 @@ defineExpose({

<span :class="ui.itemLabel({ class: props.ui?.itemLabel })">
<slot name="item-label" :item="(item as T)" :index="index">
{{ displayValue(item as T) }}
{{ typeof item === 'object' ? item.label : item }}
</slot>
</span>

Expand Down
31 changes: 17 additions & 14 deletions src/runtime/components/SelectMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ export interface SelectMenuSlots<T> {
import { computed, toRef } from 'vue'
import { ComboboxRoot, ComboboxAnchor, ComboboxInput, ComboboxTrigger, ComboboxPortal, ComboboxContent, ComboboxViewport, ComboboxEmpty, ComboboxGroup, ComboboxLabel, ComboboxSeparator, ComboboxItem, ComboboxItemIndicator, useForwardPropsEmits } from 'radix-vue'
import { defu } from 'defu'
import isEqual from 'fast-deep-equal'
import { reactivePick } from '@vueuse/core'
import { useAppConfig } from '#imports'
import { useButtonGroup } from '../composables/useButtonGroup'
Expand Down Expand Up @@ -150,16 +151,14 @@ const ui = computed(() => selectMenu({
buttonGroup: orientation.value
}))
function displayValue(val: T, multiple?: boolean): string {
if (multiple && Array.isArray(val)) {
return val.map(v => displayValue(v)).join(', ')
function displayValue(value: T): string {
if (props.multiple && Array.isArray(value)) {
return value.map(v => displayValue(v)).join(', ')
}
if (typeof val === 'object') {
return val.label
}
const item = items.value.find(item => props.valueKey ? isEqual(item[props.valueKey], value) : isEqual(item, value))
return val && String(val)
return item && (typeof item === 'object' ? item.label : item)
}
function filterFunction(items: ArrayOrWrapped<AcceptableValue>, searchTerm: string): ArrayOrWrapped<AcceptableValue> {
Expand All @@ -183,6 +182,8 @@ function filterFunction(items: ArrayOrWrapped<AcceptableValue>, searchTerm: stri
}
const groups = computed(() => props.items?.length ? (Array.isArray(props.items[0]) ? props.items : [props.items]) as SelectMenuItem[][] : [])
// eslint-disable-next-line vue/no-dupe-keys
const items = computed(() => groups.value.flatMap(group => group) as T[])
function onUpdate(value: any) {
// @ts-expect-error - 'target' does not exist in type 'EventInit'
Expand Down Expand Up @@ -227,12 +228,14 @@ function onUpdateOpen(value: boolean) {
</span>

<slot :model-value="(modelValue as T)" :open="open">
<span v-if="multiple ? modelValue?.length : modelValue !== undefined" :class="ui.value({ class: props.ui?.value })">
{{ displayValue(modelValue as T, multiple) }}
</span>
<span v-else :class="ui.placeholder({ class: props.ui?.placeholder })">
{{ placeholder ?? '&nbsp;' }}
</span>
<template v-for="displayedModelValue in [displayValue(modelValue)]" :key="displayedModelValue">
<span v-if="displayedModelValue" :class="ui.value({ class: props.ui?.value })">
{{ displayedModelValue }}
</span>
<span v-else :class="ui.placeholder({ class: props.ui?.placeholder })">
{{ placeholder ?? '&nbsp;' }}
</span>
</template>
</slot>

<span v-if="isTrailing || !!slots.trailing" :class="ui.trailing({ class: props.ui?.trailing })">
Expand Down Expand Up @@ -291,7 +294,7 @@ function onUpdateOpen(value: boolean) {

<span :class="ui.itemLabel({ class: props.ui?.itemLabel })">
<slot name="item-label" :item="(item as T)" :index="index">
{{ displayValue(item as T) }}
{{ typeof item === 'object' ? item.label : item }}
</slot>
</span>

Expand Down

0 comments on commit 0f9ac87

Please sign in to comment.