Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): move remaining classes to config #1039

Merged
merged 9 commits into from
Nov 30, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/runtime/components/elements/Button.vue
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
</slot>

<slot>
<span v-if="label" :class="[truncate ? 'text-left break-all line-clamp-1' : '']">
<span v-if="label" :class="[truncate ? ui.truncate : '']">
{{ label }}
</span>
</slot>
Expand Down Expand Up @@ -154,7 +154,7 @@ export default defineComponent({
ui.value.gap[size.value],
props.padded && ui.value[isSquare.value ? 'square' : 'padding'][size.value],
variant?.replaceAll('{color}', props.color),
props.block ? 'w-full flex justify-center items-center' : 'inline-flex items-center'
props.block ? ui.value.block : ui.value.inline
), props.class)
})

Expand All @@ -178,15 +178,15 @@ export default defineComponent({
return twJoin(
ui.value.icon.base,
ui.value.icon.size[size.value],
props.loading && 'animate-spin'
props.loading && ui.value.loading
)
})

const trailingIconClass = computed(() => {
return twJoin(
ui.value.icon.base,
ui.value.icon.size[size.value],
props.loading && !isLeading.value && 'animate-spin'
props.loading && !isLeading.value && ui.value.loading
)
})

Expand Down
2 changes: 1 addition & 1 deletion src/runtime/components/elements/Dropdown.vue
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<div v-if="open && items.length" ref="container" :class="[ui.container, ui.width]" :style="containerStyle" @mouseover="onMouseOver">
<Transition appear v-bind="ui.transition">
<div>
<div v-if="popper.arrow" data-popper-arrow :class="['invisible before:visible before:block before:rotate-45 before:z-[-1]', Object.values(ui.arrow)]" />
<div v-if="popper.arrow" data-popper-arrow :class="Object.values(ui.arrow)" />
<HMenuItems :class="[ui.base, ui.divide, ui.ring, ui.rounded, ui.shadow, ui.background, ui.height]" static>
<div v-for="(subItems, index) of items" :key="index" :class="ui.padding">
<NuxtLink v-for="(item, subIndex) of subItems" :key="subIndex" v-slot="{ href, target, rel, navigate, isExternal }" v-bind="omit(item, ['label', 'slot', 'icon', 'iconClass', 'avatar', 'shortcuts', 'disabled', 'click'])" custom>
Expand Down
6 changes: 3 additions & 3 deletions src/runtime/components/forms/Checkbox.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<div :class="ui.wrapper">
<div class="flex items-center h-5">
<div :class="ui.container">
<input
:id="inputId"
v-model="toggle"
Expand All @@ -11,13 +11,12 @@
:checked="checked"
:indeterminate="indeterminate"
type="checkbox"
class="form-checkbox"
:class="inputClass"
v-bind="attrs"
@change="onChange"
>
</div>
<div v-if="label || $slots.label" class="ms-3 flex flex-col">
<div v-if="label || $slots.label" :class="ui.inner">
<label :for="inputId" :class="ui.label">
<slot name="label">{{ label }}</slot>
<span v-if="required" :class="ui.required">*</span>
Expand Down Expand Up @@ -130,6 +129,7 @@ export default defineComponent({
const inputClass = computed(() => {
return twMerge(twJoin(
ui.value.base,
ui.value.form,
ui.value.rounded,
ui.value.background,
ui.value.border,
Expand Down
2 changes: 1 addition & 1 deletion src/runtime/components/forms/Input.vue
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
:required="required"
:placeholder="placeholder"
:disabled="disabled || loading"
class="form-input"
:class="inputClass"
v-bind="attrs"
@input="onInput"
Expand Down Expand Up @@ -234,6 +233,7 @@ export default defineComponent({

return twMerge(twJoin(
ui.value.base,
ui.value.form,
rounded.value,
ui.value.placeholder,
ui.value.size[size.value],
Expand Down
8 changes: 4 additions & 4 deletions src/runtime/components/forms/Radio.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<div :class="ui.wrapper">
<div class="flex items-center h-5">
<div :class="ui.container">
<input
:id="inputId"
v-model="pick"
Expand All @@ -9,12 +9,11 @@
:value="value"
:disabled="disabled"
type="radio"
class="form-radio"
:class="inputClass"
v-bind="attrs"
>
</div>
<div v-if="label || $slots.label" class="ms-3 flex flex-col">
<div v-if="label || $slots.label" :class="ui.inner">
<label :for="inputId" :class="ui.label">
<slot name="label">{{ label }}</slot>
<span v-if="required" :class="ui.required">*</span>
Expand Down Expand Up @@ -102,7 +101,7 @@ export default defineComponent({
const { ui, attrs } = useUI('radio', toRef(props, 'ui'), config, toRef(props, 'class'))

const radioGroup = inject('radio-group', null)
const { emitFormChange, color, name } = radioGroup ?? useFormGroup(props, config)
const { emitFormChange, color, name } = radioGroup ?? useFormGroup(props, config)
const inputId = ref(props.id)

onMounted(() => {
Expand All @@ -128,6 +127,7 @@ export default defineComponent({
const inputClass = computed(() => {
return twMerge(twJoin(
ui.value.base,
ui.value.form,
ui.value.background,
ui.value.border,
ui.value.ring.replaceAll('{color}', color.value),
Expand Down
2 changes: 1 addition & 1 deletion src/runtime/components/forms/Select.vue
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
:value="modelValue"
:required="required"
:disabled="disabled || loading"
class="form-select"
:class="selectClass"
v-bind="attrs"
@input="onInput"
Expand Down Expand Up @@ -256,6 +255,7 @@ export default defineComponent({

return twMerge(twJoin(
ui.value.base,
ui.value.form,
rounded.value,
ui.value.size[size.value],
props.padded ? ui.value.padding[size.value] : 'p-0',
Expand Down
8 changes: 4 additions & 4 deletions src/runtime/components/forms/SelectMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@
<div v-if="open" ref="container" :class="[uiMenu.container, uiMenu.width]">
<Transition appear v-bind="uiMenu.transition">
<div>
<div v-if="popper.arrow" data-popper-arrow :class="['invisible before:visible before:block before:rotate-45 before:z-[-1]', Object.values(uiMenu.arrow)]" />
<div v-if="popper.arrow" data-popper-arrow :class="Object.values(uiMenu.arrow)" />

<component :is="searchable ? 'HComboboxOptions' : 'HListboxOptions'" static :class="[uiMenu.base, uiMenu.divide, uiMenu.ring, uiMenu.rounded, uiMenu.shadow, uiMenu.background, uiMenu.padding, uiMenu.height]">
<HComboboxInput
v-if="searchable"
Expand Down Expand Up @@ -339,15 +340,14 @@ export default defineComponent({

return twMerge(twJoin(
ui.value.base,
uiMenu.value.select,
rounded.value,
'text-left cursor-default',
ui.value.size[size.value],
ui.value.gap[size.value],
props.padded ? ui.value.padding[size.value] : 'p-0',
variant?.replaceAll('{color}', color.value),
(isLeading.value || slots.leading) && ui.value.leading.padding[size.value],
(isTrailing.value || slots.trailing) && ui.value.trailing.padding[size.value],
'inline-flex items-center'
(isTrailing.value || slots.trailing) && ui.value.trailing.padding[size.value]
), props.selectClass)
})

Expand Down
2 changes: 1 addition & 1 deletion src/runtime/components/forms/Textarea.vue
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
:required="required"
:disabled="disabled"
:placeholder="placeholder"
class="form-textarea"
:class="textareaClass"
v-bind="attrs"
@input="onInput"
Expand Down Expand Up @@ -227,6 +226,7 @@ export default defineComponent({

return twMerge(twJoin(
ui.value.base,
ui.value.form,
ui.value.rounded,
ui.value.placeholder,
ui.value.size[size.value],
Expand Down
3 changes: 2 additions & 1 deletion src/runtime/components/overlays/ContextMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
<div v-if="isOpen" ref="container" :class="wrapperClass" v-bind="attrs">
<Transition appear v-bind="ui.transition">
<div>
<div v-if="popper.arrow" data-popper-arrow :class="['invisible before:visible before:block before:rotate-45 before:z-[-1]', Object.values(ui.arrow)]" />
<div v-if="popper.arrow" data-popper-arrow :class="Object.values(ui.arrow)" />

<div :class="[ui.base, ui.ring, ui.rounded, ui.shadow, ui.background]">
<slot />
</div>
Expand Down
3 changes: 2 additions & 1 deletion src/runtime/components/overlays/Popover.vue
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
<div v-if="(open !== undefined) ? open : headlessOpen" ref="container" :class="[ui.container, ui.width]" :style="containerStyle" @mouseover="onMouseOver">
<Transition appear v-bind="ui.transition">
<div>
<div v-if="popper.arrow" data-popper-arrow :class="['invisible before:visible before:block before:rotate-45 before:z-[-1]', Object.values(ui.arrow)]" />
<div v-if="popper.arrow" data-popper-arrow :class="Object.values(ui.arrow)" />

<HPopoverPanel :class="[ui.base, ui.background, ui.ring, ui.rounded, ui.shadow]" static>
<slot name="panel" :open="(open !== undefined) ? open : headlessOpen" :close="close" />
</HPopoverPanel>
Expand Down
5 changes: 3 additions & 2 deletions src/runtime/components/overlays/Tooltip.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,16 @@
<div v-if="open && !prevent" ref="container" :class="[ui.container, ui.width]">
<Transition appear v-bind="ui.transition">
<div>
<div v-if="popper.arrow" data-popper-arrow :class="['invisible before:visible before:block before:rotate-45 before:z-[-1]', Object.values(ui.arrow)]" />
<div v-if="popper.arrow" data-popper-arrow :class="Object.values(ui.arrow)" />

<div :class="[ui.base, ui.background, ui.color, ui.rounded, ui.shadow, ui.ring]">
<slot name="text">
{{ text }}
</slot>

<span v-if="shortcuts?.length" :class="ui.shortcuts">
<span class="mx-1 text-gray-700 dark:text-gray-200">&middot;</span>

<UKbd v-for="shortcut of shortcuts" :key="shortcut" size="xs">
{{ shortcut }}
</Ukbd>
Expand Down
6 changes: 5 additions & 1 deletion src/runtime/ui.config/elements/button.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ export default {
base: 'focus:outline-none focus-visible:outline-0 disabled:cursor-not-allowed disabled:opacity-75 flex-shrink-0',
font: 'font-medium',
rounded: 'rounded-md',
truncate: 'text-left break-all line-clamp-1',
block: '',
inline: '',
benjamincanac marked this conversation as resolved.
Show resolved Hide resolved
loading: 'animate-spin',
size: {
'2xs': 'text-xs',
xs: 'text-xs',
Expand Down Expand Up @@ -73,4 +77,4 @@ export default {
color: 'primary',
loadingIcon: 'i-heroicons-arrow-path-20-solid'
}
}
}
6 changes: 3 additions & 3 deletions src/runtime/ui.config/elements/dropdown.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import _popperArrow from '../_popperArrow'
import { arrow } from '../popper'

export default {
wrapper: 'relative inline-flex text-left rtl:text-right',
Expand Down Expand Up @@ -45,8 +45,8 @@ export default {
strategy: 'fixed'
},
arrow: {
..._popperArrow,
...arrow,
ring: 'before:ring-1 before:ring-gray-200 dark:before:ring-gray-700',
background: 'before:bg-white dark:before:bg-gray-700'
}
}
}
5 changes: 4 additions & 1 deletion src/runtime/ui.config/forms/checkbox.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
export default {
wrapper: 'relative flex items-start',
container: 'flex items-center h-5',
base: 'h-4 w-4 dark:checked:bg-current dark:checked:border-transparent dark:indeterminate:bg-current dark:indeterminate:border-transparent disabled:opacity-50 disabled:cursor-not-allowed focus:ring-0 focus:ring-transparent focus:ring-offset-transparent',
form: 'form-checkbox',
rounded: 'rounded',
color: 'text-{color}-500 dark:text-{color}-400',
background: 'bg-white dark:bg-gray-900',
border: 'border border-gray-300 dark:border-gray-700',
ring: 'focus-visible:ring-2 focus-visible:ring-{color}-500 dark:focus-visible:ring-{color}-400 focus-visible:ring-offset-2 focus-visible:ring-offset-white dark:focus-visible:ring-offset-gray-900',
inner: 'ms-3 flex flex-col',
label: 'text-sm font-medium text-gray-700 dark:text-gray-200',
required: 'text-sm text-red-500 dark:text-red-400',
help: 'text-sm text-gray-500 dark:text-gray-400',
default: {
color: 'primary'
}
}
}
3 changes: 2 additions & 1 deletion src/runtime/ui.config/forms/input.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
export default {
wrapper: 'relative',
base: 'relative block w-full disabled:cursor-not-allowed disabled:opacity-75 focus:outline-none border-0',
form: 'form-input',
rounded: 'rounded-md',
placeholder: 'placeholder-gray-400 dark:placeholder-gray-500',
size: {
Expand Down Expand Up @@ -101,4 +102,4 @@ export default {
variant: 'outline',
loadingIcon: 'i-heroicons-arrow-path-20-solid'
}
}
}
5 changes: 4 additions & 1 deletion src/runtime/ui.config/forms/radio.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
export default {
wrapper: 'relative flex items-start',
container: 'flex items-center h-5',
base: 'h-4 w-4 dark:checked:bg-current dark:checked:border-transparent disabled:opacity-50 disabled:cursor-not-allowed focus:ring-0 focus:ring-transparent focus:ring-offset-transparent',
form: 'form-radio',
color: 'text-{color}-500 dark:text-{color}-400',
background: 'bg-white dark:bg-gray-900',
border: 'border border-gray-300 dark:border-gray-700',
ring: 'focus-visible:ring-2 focus-visible:ring-{color}-500 dark:focus-visible:ring-{color}-400 focus-visible:ring-offset-2 focus-visible:ring-offset-white dark:focus-visible:ring-offset-gray-900',
inner: 'ms-3 flex flex-col',
label: 'text-sm font-medium text-gray-700 dark:text-gray-200',
required: 'text-sm text-red-500 dark:text-red-400',
help: 'text-sm text-gray-500 dark:text-gray-400',
default: {
color: 'primary'
}
}
}
3 changes: 2 additions & 1 deletion src/runtime/ui.config/forms/select.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import input from './input'

export default {
...input,
form: 'form-select',
placeholder: 'text-gray-900 dark:text-white',
default: {
size: 'sm',
Expand All @@ -10,4 +11,4 @@ export default {
loadingIcon: 'i-heroicons-arrow-path-20-solid',
trailingIcon: 'i-heroicons-chevron-down-20-solid'
}
}
}
7 changes: 4 additions & 3 deletions src/runtime/ui.config/forms/selectMenu.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import _popperArrow from '../_popperArrow'
import { arrow } from '../popper'

export default {
select: 'inline-flex items-center text-left cursor-default',
container: 'z-20 group',
width: 'w-full',
height: 'max-h-60',
Expand Down Expand Up @@ -55,8 +56,8 @@ export default {
clearOnClose: false
},
arrow: {
..._popperArrow,
...arrow,
ring: 'before:ring-1 before:ring-gray-200 dark:before:ring-gray-700',
background: 'before:bg-white dark:before:bg-gray-700'
}
}
}
3 changes: 2 additions & 1 deletion src/runtime/ui.config/forms/textarea.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ import input from './input'

export default {
...input,
form: 'form-textarea',
default: {
size: 'sm',
color: 'white',
variant: 'outline'
}
}
}
4 changes: 2 additions & 2 deletions src/runtime/ui.config/overlays/contextMenu.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import arrow from '../_popperArrow'
import { arrow } from '../popper'

export default {
wrapper: 'relative',
Expand All @@ -23,4 +23,4 @@ export default {
scroll: false
},
arrow
}
}
2 changes: 1 addition & 1 deletion src/runtime/ui.config/overlays/popover.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import arrow from '../_popperArrow'
import { arrow } from '../popper'

export default {
wrapper: 'relative',
Expand Down
Loading