Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ColorPicker)!: migrate from color to colortranslator #3097

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

hywax
Copy link
Collaborator

@hywax hywax commented Jan 14, 2025

πŸ”— Linked issue

Resolves #2922

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Removed hwb from important, but added CIELab and cmyk in its place.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@hywax
Copy link
Collaborator Author

hywax commented Jan 14, 2025

@marco-land @gunhaxxor since you are interested in this, I inform you that there will be changes to this component

Copy link

pkg-pr-new bot commented Jan 14, 2025

npm i https://pkg.pr.new/@nuxt/ui@3097

commit: 5a99b25

@hywax hywax added the v3 #1289 label Jan 14, 2025
@gunhaxxor
Copy link

Nice work! I'm wondering if it could be an issue with the color-translator lib weighing 184 kB. Compared to the replaced package "color" that's only 16.8 kB.
I was considering esm-color which claims to be tree-shakable and should therefore have a small footprint.
I guess color-translator isnt tree-shakable, as its wrapping most functionality in the instantiated ColorTranslator object?

Perhaps it's neglilable with 184kb, but I have a feeling its quite a lot for the small amount of functionality needed?

@hywax
Copy link
Collaborator Author

hywax commented Jan 14, 2025

@gunhaxxor https://bundlephobia.com/package/[email protected]

@benjamincanac benjamincanac changed the title refactor(ColorPicker)!: migrate form color to colortranslator refactor(ColorPicker)!: migrate from color to colortranslator Jan 14, 2025
@benjamincanac benjamincanac merged commit 51e5e65 into nuxt:v3 Jan 14, 2025
2 checks passed
@benjamincanac
Copy link
Member

Thanks @hywax! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
3 participants