Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): fixed row deletion bug on deselect #425

Merged
merged 2 commits into from
Jul 18, 2023
Merged

fix(Table): fixed row deletion bug on deselect #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a023d7
bugfix(Table): fixed row deletion bug on deselect
johnpuaoi Jul 18, 2023
d2eb1f9
up
benjamincanac Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions docs/content/4.data/1.table.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,9 +327,7 @@ const selected = ref([people[1]])
You can use the `by` prop to compare objects by a field instead of comparing object instances. We've replicated the behavior of Headless UI [Combobox](https://headlessui.com/vue/combobox#binding-objects-as-values).
::

### Clickable

Add a `select` listener on your Table to make the rows clickable. The function will receive the row as the first argument.
You can alsso add a `select` listener on your Table to make the rows clickable. The function will receive the row as the first argument.

You can use this to navigate to a page, open a modal or even to select the row manually.

Expand Down
24 changes: 22 additions & 2 deletions src/runtime/components/data/Table.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<thead :class="ui.thead">
<tr :class="ui.tr.base">
<th v-if="modelValue" scope="col" class="ps-4">
<UCheckbox :checked="indeterminate || selected.length === rows.length" :indeterminate="indeterminate" @change="selected = $event.target.checked ? rows : []" />
<UCheckbox :checked="indeterminate || selected.length === rows.length" :indeterminate="indeterminate" @change="onChange" />
</th>

<th v-for="(column, index) in columns" :key="index" scope="col" :class="[ui.th.base, ui.th.padding, ui.th.color, ui.th.font, ui.th.size, column.class]">
Expand Down Expand Up @@ -210,6 +210,25 @@ export default defineComponent({
attrs.onSelect(row)
}

function selectAllRows () {
props.rows.forEach((row) => {
// If the row is already selected, don't select it again
if (selected.value.some((item) => compare(toRaw(item), toRaw(row)))) {
return
}

onSelect(row)
})
}

function onChange (event: any) {
if (event.target.checked) {
selectAllRows()
} else {
selected.value = []
}
}

return {
// eslint-disable-next-line vue/no-dupe-keys
ui,
Expand All @@ -225,7 +244,8 @@ export default defineComponent({
emptyState,
isSelected,
onSort,
onSelect
onSelect,
onChange
}
}
})
Expand Down