fix(Table): fixed row deletion bug on deselect #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Live Preview ready!
|
benjamincanac
changed the title
benjamincanac
approved these changes
Jul 18, 2023
|
Thanks 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you select all items in a table with the header checkbox and attempt to deselect a row by clicking on the row itself and not the checkbox, that row will be deleted from the rows prop. I believe this was caused by the @change because selected was being set to rows itself.
Switched to calling onSelect for all rows in a foreach when selecting all rows, so that that handler in the parent component can remove the item without removing it from rows.
I apologize in advance for any hiccups, this is my first PR ever (I'm a solo dev).
Mahalo!